Closed asivaneswaran closed 6 months ago
@DarkGhostHunter Can you take a look and see if we can merge this?
Patch coverage is 66.66%
of modified lines.
Files Changed | Coverage |
---|---|
.../Creator/Pipes/MayRetrieveCredentialsIdForUser.php | ø |
src/Attestation/AuthenticatorData.php | ø |
...rtion/Validator/Pipes/CheckCredentialIsForUser.php | 66.66% |
:loudspeaker: Thoughts on this report? Let us know!.
@DarkGhostHunter The checks that are failing are from code that was untouched, is it a blocker for the merge?
Yeah, but is mostly static analysis. Be sure to change whatever it's needed to tests can pass.
@DarkGhostHunter Can you run the checks, everything should be fixed.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Went my own way with a simplier fix.
51
We are passing the user_id in a plain text as sometimes it's not returned by the browser.