Laragear / WebAuthn

Authenticate users with Passkeys: fingerprints, patterns and biometric data.

MIT License

295 stars 37 forks source link

Closed asivaneswaran closed 6 months ago

asivaneswaran commented 1 year ago

51

We are passing the user_id in a plain text as sometimes it's not returned by the browser.

asivaneswaran commented 12 months ago

@DarkGhostHunter Can you take a look and see if we can merge this?

codecov[bot] commented 12 months ago

Patch coverage is 66.66% of modified lines.

Files Changed	Coverage
.../Creator/Pipes/MayRetrieveCredentialsIdForUser.php	`ø`
src/Attestation/AuthenticatorData.php	`ø`
...rtion/Validator/Pipes/CheckCredentialIsForUser.php	`66.66%`

:loudspeaker: Thoughts on this report? Let us know!.

asivaneswaran commented 11 months ago

@DarkGhostHunter The checks that are failing are from code that was untouched, is it a blocker for the merge?

DarkGhostHunter commented 11 months ago

Yeah, but is mostly static analysis. Be sure to change whatever it's needed to tests can pass.

asivaneswaran commented 11 months ago

@DarkGhostHunter Can you run the checks, everything should be fixed.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!

No Coverage information
0.0% Duplication

DarkGhostHunter commented 6 months ago

Went my own way with a simplier fix.