search

Laragear / WebAuthn

Authenticate users with Passkeys: fingerprints, patterns and biometric data.
MIT License
305 stars 37 forks source link

Add http scheme in url #53

Closed asivaneswaran closed 8 months ago

asivaneswaran commented 1 year ago

50

asivaneswaran commented 1 year ago

@DarkGhostHunter Can you take a look and see if we can merge this?

asivaneswaran commented 1 year ago

@DarkGhostHunter I fixed the 2 errors related to this MR.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
.../Creator/Pipes/MayRetrieveCredentialsIdForUser.php ø
src/Attestation/AuthenticatorData.php ø
...tion/Validator/Pipes/CheckRelyingPartyHashSame.php 100.00%
...tion/Validator/Pipes/CheckRelyingPartyHashSame.php 100.00%
src/SharedPipes/CheckRelyingPartyIdContained.php 100.00%

:loudspeaker: Thoughts on this report? Let us know!.

asivaneswaran commented 1 year ago

@DarkGhostHunter Can you run the checks, everything should be fixed.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

asivaneswaran commented 1 year ago

@DarkGhostHunter Can we merge this PR please?

asivaneswaran commented 1 year ago

@DarkGhostHunter Would it be possible to merge this please?

asivaneswaran commented 1 year ago

Is this package still maintained?

DarkGhostHunter commented 1 year ago

Is this package still maintained?

Yes, but I'm hands full under contract. Once it ends, I will get back into reviewing all PR's across the org.

asivaneswaran commented 11 months ago

Hey, any news on this?

We are using the package and we need to start testing our tickets and we can't test until these PR's are merged.

I am not trying to rush you or anything, just wondering if I need to fork it until you can merge these or not.

DarkGhostHunter commented 11 months ago

Fork it. I’m still under contract since the project got delayed. Italo Baeza C.El 08-11-2023, a la(s) 15:31, asivaneswaran @.***> escribió: Hey, any news on this? We are using the package and we need to start testing our tickets and we can't test until these PR's are merged. I am not trying to rush you or anything, just wondering if I need to fork it until you can merge these or not.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

DarkGhostHunter commented 8 months ago

Went my own way #65