Laragear / WebAuthn

Authenticate users with Passkeys: fingerprints, patterns and biometric data.

MIT License

295 stars 37 forks source link

[3.x] Native Android and iOS implementation integration support #84

Closed illambo closed 1 month ago

illambo commented 4 months ago

Description

resolve #82

@DarkGhostHunter can u help me with tests? See the test fails Tests\Assertion\ValidationTest@test_check_origin_pass_if_in_additional_allowed_origins it throw Laragear\WebAuthn\Exceptions\AssertionException: Assertion Error: Signature is invalid: error:0480006C:PEM routines::no

Otherwise when I have a little more time I'll try to finalize (I have to better understand the logic of the FakeAuthenticator)

Feel free to adapt the code if necessary as more valid for the style of the library.

illambo commented 4 months ago

I have currently completed the battery of tests by mocking the CheckPublicKeySignature@validateWithOpenSsl method in order to avoid having to create an ad hoc FakeAuthenticator. If it's not enough let me know, I think I'll need a little more time to understand and produce the correct and valid data for the test battery. Thanks.

illambo commented 4 months ago

I tested the PR with Android authenticator and native implementation via credential manager and it works correctly.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (3.x@395cba6). Learn more about missing BASE report.

:exclamation: Current head 11dafa8 differs from pull request most recent head b1766a4

Please upload reports for the commit b1766a4 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 3.x #84 +/- ## ====================================== Coverage ? 84.09% Complexity ? 432 ====================================== Files ? 70 Lines ? 1069 Branches ? 0 ====================================== Hits ? 899 Misses ? 170 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

illambo commented 3 months ago

Hi @DarkGhostHunter do you have any news on this? Thanks.

DarkGhostHunter commented 3 months ago

I'm going to edit your PR, but to do that I have to setup my old dev machine all over again, so everything is paused until I'm done with my task queue.