Closed illambo closed 1 month ago
I have currently completed the battery of tests by mocking the CheckPublicKeySignature@validateWithOpenSsl
method in order to avoid having to create an ad hoc FakeAuthenticator
.
If it's not enough let me know, I think I'll need a little more time to understand and produce the correct and valid data for the test battery.
Thanks.
I tested the PR with Android authenticator and native implementation via credential manager and it works correctly.
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
3.x@395cba6
). Learn more about missing BASE report.:exclamation: Current head 11dafa8 differs from pull request most recent head b1766a4
Please upload reports for the commit b1766a4 to get more accurate results.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @DarkGhostHunter do you have any news on this? Thanks.
I'm going to edit your PR, but to do that I have to setup my old dev machine all over again, so everything is paused until I'm done with my task queue.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
any updates?
@DarkGhostHunter can u merge this plz?
Hi, do you think it can be integrated for September? Maybe the whole v3? Thank you.
Task queue still not empty, but I should resolve this before this month ends.
👍 thanks
Closing this in favor if #91
Description
resolve #82
@DarkGhostHunter can u help me with tests? See the test fails
Tests\Assertion\ValidationTest@test_check_origin_pass_if_in_additional_allowed_origins
it throwLaragear\WebAuthn\Exceptions\AssertionException: Assertion Error: Signature is invalid: error:0480006C:PEM routines::no
Otherwise when I have a little more time I'll try to finalize (I have to better understand the logic of the FakeAuthenticator)
Feel free to adapt the code if necessary as more valid for the style of the library.