Laragear / WebAuthn

Authenticate users with Passkeys: fingerprints, patterns and biometric data.
MIT License
295 stars 37 forks source link

[3.x] Removes left in error-prone string #92

Closed DarkGhostHunter closed 1 month ago

DarkGhostHunter commented 1 month ago

Left out from #91

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

szepeviktor commented 1 month ago

Very lingering. Let's do something about it!

DarkGhostHunter commented 1 month ago

Very lingering.

Let's do something about it!

Already did. Not longer lingering.

szepeviktor commented 1 month ago

I mean in an automated way, without you.

szepeviktor commented 1 month ago

@DarkGhostHunter Turns out it is a goto label 😲 https://github.com/phpstan/phpstan/issues/11406#issuecomment-2254989636

DarkGhostHunter commented 1 month ago

Thanks for pushing it upstream ;)