Laravel-Backpack / BackupManager

Admin interface for managing database and file backups in Backpack for Laravel
http://backpackforlaravel.com
Other
333 stars 93 forks source link

Call to undefined method League\Flysystem\Filesystem::getAdapter() #100

Closed phpust closed 2 years ago

phpust commented 2 years ago

Bug report

hi, i am running backpack 5 on laravel 9. there is a problem with this package and obviously it is not from spatie.

What I did:

after going to backups page in admin panel i get an error with this title ( "Call to undefined method League\Flysystem\Filesystem::getAdapter()" )

What I expected to happen:

look like problem is from -> https://github.com/Laravel-Backpack/BackupManager/blob/4c1878c4edfd37c0d2aa0adbe81add9dcb56d274/src/app/Http/Controllers/BackupController.php#L26

``

What happened:

it try to get driver letter and calling getAdapter on it.
$adapter = $disk->getDriver()->getAdapter();

What I've already tried to fix it:

look like getDriver() is redundant and must be removed, final code will look like this: $adapter = $disk->getAdapter();

Backpack, Laravel, PHP, DB version:

BackPack 5 Laravel 9.0

welcome[bot] commented 2 years ago

Hello there! Thanks for opening your first issue on this repo! Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that. Backpack communication mediums:

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch. Thank you! -- Justin Case The Backpack Robot

phpust commented 2 years ago

the full error is currently shown in this link : https://flareapp.io/share/87nzy167#F52

tabacitu commented 2 years ago

Thank you @phpust and sorry for leaving this unattended for so long. It's now fixed in #102 which will fix this and a few more things. It'll be merged in a few days.

Thank you for your patience! 🙏