Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3.17k stars 896 forks source link

[Feature Request] Show AJAX errors in bubble notifications #3830

Closed promatik closed 3 years ago

promatik commented 3 years ago

Feature Request

What's the feature you think Backpack should have?

Better error messages on CRUD table ajax errors. As we did on DevTools, it could be done for the list view. Developers may open the Network panel and there are full details of the error, but, we could also give a preview of it.

Note, this would work on local environment only.

Should we?

image

Have you already implemented a prototype solution, for your own project?

This was done on DevTools, and it works 🤷‍♂️

tabacitu commented 3 years ago

I think we definitely SHOULD do this. But go a step further than what we did in DevTools and show the entire error stack, in a modal. That should be possible right?

My reasoning for this is this:

Showing the full error stack in a modal would basically render the Network tab useless when dealing with AJAX errors in Backpack, which I think could be a huge developer experience improvement.

promatik commented 3 years ago

Yes, it should be possible, and I agree 👌

But I also think we shouldn't be reinventing the wheel 😅 it would be nice to use the default Laravel error page, maybe inside an iframe, exactly like Livewire does...

tabacitu commented 3 years ago

See https://github.com/Laravel-Backpack/CRUD/pull/3836 for POC/WIP

promatik commented 3 years ago

Since both are in the same project, let's move conversation about this to; #3836