search

Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3.08k stars 886 forks source link

Update styles.blade.php #5404

Closed realtebo closed 8 months ago

realtebo commented 9 months ago

Added woff and ttf to force import from bassets

WHY

BEFORE - What was wrong? What was happening before this PR?

Some browser are requiring ttf or woff version of line awesome files So users cannot see icons in the coreui-v4

AFTER - What is happening after this PR?

With this PR, we can do a basset:internalize and predownload all required files. Also, we fix the behaviour with icons don't loaded

HOW

Added @basset instructions for woff and ttf file of used files

How did you achieve that, in technical terms?

Added @basset instructions for woff and ttf file of used files

Is it a breaking change?

No

How can we test the before & after?

IDK, sorry

jcastroa87 commented 9 months ago

Hello @realtebo thanks for your PR.

I will ask @promatik to check this new code and if everything is ok will be merged.

Thanks again.

Cheers.

realtebo commented 9 months ago

This is importing a file in the term of saving it to disk if we internalize assets. But it will not be downloaded if not needed by production code

Anyway, the problem is not solved at all. Some chrome on some random android phones (not old!) are still not showing icons so the problem is not related to alternative versions of file.

I suggest, anyway, to merge this PR for sake of completeness because it's not causing side-effects.

But i will open an issue asking for help to resolve the main concerns

pxpm commented 8 months ago

Thanks @realtebo for the PR 🙏

I agree, there is no issue having both, even for browser compatibility, if the any css implement a fallback system it will work without adding the files manually.

Let me know if I can help you with something else.

Cheers