Closed emjayess closed 3 months ago
Hello there! Thanks for opening your first issue on this repo!
Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.
Backpack communication channels:
backpack-for-laravel
tag;Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.
Thank you!
-- Justin Case The Backpack Robot
Hey @emjayess
Thanks for reporting your findings & proposing a solution. I appreciate your efforts and time. My will colleague @pxpm will review it.
Cheers!
Sorry @emjayess it took me so much time to get back here, I totally missed this. 😞
I've just fixed it in backpack/crud:6.7.14
Thanks for the heads up 🙏
Bug discovered, here:
https://github.com/Laravel-Backpack/CRUD/blob/de5668b0b3742877ed6577a5972ac85326ddd46b/src/resources/views/ui/inc/getting_started.blade.php#L42-L44
Summary and findings
☝🏼 In the Getting Started card guide include, (3.) prescribes this extra hashing of
$entry->password
inside ofsetupCreateOperation()
.In trying and testing this, I found that a user created while this code was in place could not, in fact, log in using the provided password.
Upon further testing and inspection of both
$entry->password
and alsorequest('password')
, what seems to be the case is that$entry->password
has already been hashed (by laravel?), and so invoking\Hash::make()
on this value is hashing a hash, thus breaking this user's ability to log in with the originally provided password.Proposed resolution:
Simply remove this recommendation or prescribed code block
Php, Laravel, and Backpack version(s) context / report =>