Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3.04k stars 885 forks source link

Remove extra dot from breadcrumbs after entity name #5430

Closed kamrul-bd closed 6 months ago

kamrul-bd commented 7 months ago

WHY

Need to remove this extra dot from breadcrumbs in create and edit view.

BEFORE - What was wrong? What was happening before this PR?

There is an extra dot(.) after entity name on breadcrumbs in create and edit view. dot-issue

AFTER - What is happening after this PR?

Removed the dot from breadcrumbs.

HOW

Just remove the dot(.) from create.blade.php and edit.blade.php

How did you achieve that, in technical terms?

??

Is it a breaking change?

No

How can we test the before & after?

Just check the breadcrumbs in create and edit page.

If the PR has changes in multiple repos please provide the command to checkout all branches, eg.:

git checkout "dev-branch-name" &&
cd vendor/backpack/crud && git checkout crud-branch-name &&
cd ../pro && git checkout pro-branch-name &&
cd ../../..
karandatwani92 commented 6 months ago

Hey @kamrul-bd

The "." is not the part of the breadcrumb. I can see, it is placed after the action description which looks fine to me. I don't see any issue there.

Thanks for the PR.