Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3k stars 880 forks source link

[v7] Reorder HasForm trait parameters #5459

Open pxpm opened 4 months ago

pxpm commented 4 months ago

WHY

BEFORE - What was wrong? What was happening before this PR?

Optional parameters before required are deprecated. They are "technically" required as pointed in #5458 .

AFTER - What is happening after this PR?

We change the order of the parameters. It's a breaking change. In preparation for that, I've created https://github.com/Laravel-Backpack/Generators/pull/204 that from now on will generate the stub with named parameters.

That way, this will not be a breaking change for developers that create their new forms with the command as the named parameters will ensure no breaking change for them.