Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3k stars 880 forks source link

[Bug] Call to undefined method Backpack\Basset\BassetManager::echoJs() #5493

Closed bartjuh4 closed 3 months ago

bartjuh4 commented 3 months ago

Bug report

What I did

Updated dependency backpack/crud to v6.7.6

What I expected to happen

No errors

What happened

Call to undefined method Backpack\Basset\BassetManager::echoJs() when calling @loadScriptOnce() blade directive in a template.

What I've already tried to fix it

Switched loadScriptOnce to @basset(), this fixed the issue, but this should not break right?

Is it a bug in the latest version of Backpack?

Yes

Backpack, Laravel, PHP, DB version

PHP VERSION:

8.3.4

LARAVEL VERSION:

11.3.1.0

BACKPACK PACKAGE VERSIONS:

backpack/basset: 1.3.1 backpack/crud: 6.7.6 backpack/generators: v4.0.5 backpack/permissionmanager: 7.2.0 backpack/pro: 2.1.12 backpack/theme-coreuiv2: 1.2.3

welcome[bot] commented 3 months ago

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

bartjuh4 commented 3 months ago

echoJs was removed here: https://github.com/Laravel-Backpack/basset/commit/3f2e7c9427e8c5f5c07a39c600d8955978f7a53d but references to this method are not removed or updated.

bartjuh4 commented 3 months ago

It also show a huge spinner below datatables since the package update.

vendor/backpack/crud/src/resources/views/crud/inc/datatables_logic.blade.php line 16 outputs an image since the last version.

I have no modified template files, i only use the vendor template files.

Scherm­afbeelding 2024-04-13 om 09 00 25
jcastroa87 commented 3 months ago

Hi @bartjuh4

Pedro will take this issue to check and fix it as needed.

Thanks for reporting this issue.

Cheers.

pxpm commented 3 months ago

Hey @jcastroa87 sorry my bad on this one.

I already merged and released the fixed version. https://github.com/Laravel-Backpack/basset/releases/tag/1.3.2

I saw @bartjuh4 gave an 👍 on the PR when I merged it so I didn't came back here to reply to him.

I think by this time we can close this issue.

Please @bartjuh4 let us know if you still experiencing issue 🙏

Cheers