search

Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
2.99k stars 880 forks source link

DB schema was loading ALL tables when not necessary #5504

Closed pxpm closed 2 months ago

pxpm commented 2 months ago

Some of my latest changes in the upgrade to Laravel 11, made the DB schema class a little to eager to get the table information, that was requesting information from tables that we are not specifically using in certain cruds.

In big applications it could lead to some performance issues.

@promatik can you confirm this brings back the previous behavior ?

I've tested this in L10 with dbal and L11 using the Laravel native classes.

jnoordsij commented 2 months ago

Thanks for this fix @pxpm! Just tried this out locally and on my dev environment everything seems to work fine and the additional queries are gone.

pxpm commented 2 months ago

Thanks for this fix @pxpm! Just tried this out locally and on my dev environment everything seems to work fine and the additional queries are gone.

Thanks for confirming, much appreciated 👍

I was just giving this a final test with L10/L11 + Devtools (that uses this functionality too). Everything seems to be working on my side too, I should merge and tag the fixed version in a few moments.

Thanks again 🙏