BEFORE - What was wrong? What was happening before this PR?
When basset is in Dev mode, calling Basset::basset($asset) marks it as loaded even if not internalized.
We have two options here:
as I did, don't attempt to load local file (that doesn't exist) while in dev mode.
remove LOADED from the array of valid asset status.
This PR works as expected and is the easiest (from the side effects perspective), but removing LOADED from the status array is the cleanest, so I opened this PR in the hopes that we can remove the LOADED, but I am not sure about all the implications, nor why LOADED was added there.
Maybe for the use case when you have multiple backpack_avatar_url() calls ?
WHY
BEFORE - What was wrong? What was happening before this PR?
When basset is in Dev mode, calling
Basset::basset($asset)marks it as loaded even if not internalized.We have two options here:
This PR works as expected and is the easiest (from the side effects perspective), but removing
LOADEDfrom the status array is the cleanest, so I opened this PR in the hopes that we can remove the LOADED, but I am not sure about all the implications, nor why LOADED was added there. Maybe for the use case when you have multiplebackpack_avatar_url()calls ?Clarify my doubts here @promatik 🙏