Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3k stars 880 forks source link

Fix typo in dd helper method docblocks #5530

Closed Kasparsu closed 1 month ago

Kasparsu commented 1 month ago

WHY

Typos in DocBlocks reduce readability of the code and makes it harder to understand underlying methods actions and intents.

BEFORE - What was wrong? What was happening before this PR?

dd method in Backpack\CRUD\app\Library DocBlocks had a typo in them

AFTER - What is happening after this PR?

dd method in Backpack\CRUD\app\Library DocBlocks don't have a typo in them

HOW

How did you achieve that, in technical terms?

I used my great english skills and my keyboard backspace (™ pending) button to remove extra u from the word Duumps.

Is it a breaking change?

No

How can we test the before & after?

Use built in feature in every developer called eyes. Confirm that typo is truly gone.

welcome[bot] commented 1 month ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

jcastroa87 commented 1 month ago

Hello @Kasparsu

Thanks a lot, i will ask @pxpm to check and merge if everything is ok.

Thanks again.

tabacitu commented 1 month ago

Excellent PR, thank you @Kasparsu . So well written too, thank you for taking the time to explain how you achieved it. And of course, thank you for using your proprietary method 🙏 (hope we won't be infringing on your TM when it's accepted).

welcome[bot] commented 1 month ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!