Closed Kasparsu closed 1 month ago
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.
Please keep in mind that:
Thank you!
-- Justin Case The Backpack Robot
Hello @Kasparsu
Thanks a lot, i will ask @pxpm to check and merge if everything is ok.
Thanks again.
Excellent PR, thank you @Kasparsu . So well written too, thank you for taking the time to explain how you achieved it. And of course, thank you for using your proprietary method 🙏 (hope we won't be infringing on your TM when it's accepted).
WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.
You should also receive an email inviting you to the Community Members team. That's where we, commited community members, debate new features and decide what's in the Backpack roadmap. Feel free to ignore the invitation if you're not interested :-)
If you want to help out the community in other ways, you can:
backpack-for-laravel
tag by adding a new filter; that will send you emails when new questions come up with our tag;Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!
-- Justin Case The Backpack Robot
P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please apply for free licenses and mention this PR. You scratch my back, I scratch your back. Thank you!
WHY
Typos in DocBlocks reduce readability of the code and makes it harder to understand underlying methods actions and intents.
BEFORE - What was wrong? What was happening before this PR?
dd
method inBackpack\CRUD\app\Library
DocBlocks had a typo in themAFTER - What is happening after this PR?
dd
method inBackpack\CRUD\app\Library
DocBlocks don't have a typo in themHOW
How did you achieve that, in technical terms?
I used my great english skills and my keyboard backspace (™ pending) button to remove extra
u
from the wordDuumps
.Is it a breaking change?
No
How can we test the before & after?
Use built in feature in every developer called
eyes
. Confirm that typo is truly gone.