search

Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3.11k stars 890 forks source link

Remove misleading free licence text from Backpack Robot #5533

Closed Kasparsu closed 4 months ago

Kasparsu commented 4 months ago

WHY

Misleading robot text would cause unfair stress upon Backpack core team.

BEFORE - What was wrong? What was happening before this PR?

Robot would direct new contributors to now defunct feature of getting free licensing.

AFTER - What is happening after this PR?

Robot no longer offers any compensation to contributors for their hard work.

HOW

How did you achieve that, in technical terms?

Used my keyboard backspace (™ pending) button to remove extra line about licensing from robots text configuration

Is it a breaking change?

No

How can we test the before & after?

Wait robot to congratulate a new contributor and check if he still offers free licensing.

pxpm commented 4 months ago

Hey @Kasparsu thanks for the PR 🙏

I've seen this message so many times in my life, that I don't read it for years, if you asked me now what the robot says, I couldn't tell you without going to see the robot answer 😄

The advertising of free licenses and the corresponding form on the website was removed about a month ago if I remember correctly, so yeah, we should remove the message from the robot too.

If you were one of those mislead persons, as I assume you were, I am sorry for the trouble, the intention was never to mislead the users to work thinking they would be compensated without actually doing it. We delivered hundreds of free licenses for contributors during this years, but actually keeping track of the contributions, issuing the licenses etc was becoming a pain point to maintain in our structure.

Contributions are still welcomed, if you feel you made a good contribution and would like to ask to be appreciated with a discount or a license you can still reach us at hello@backpackforlaravel.com, we just don't advertise it as we don't plan to have that as a "rule of thumb".

User contributions via PRs, Issues, Suggestions etc is the biggest factor for us to be here so we surely appreciate it and value it, after all Backpack/CRUD is MIT License, so it benefits the whole community.

Once again, thanks for taking the time to submit the PR.

Cheers