Laravel-Backpack / CRUD

Build custom admin panels. Fast!
https://backpackforlaravel.com
MIT License
3k stars 880 forks source link

[Bug] Gravatar doesn't get loaded twice in dev mode. #5537

Open Kasparsu opened 1 month ago

Kasparsu commented 1 month ago

Bug report

What I did

Loaded a sidebar layout admin view

What I expected to happen

gravatar to be showed both in side panel and mobile view navbar

What happened

It loads mobile view top bar correctly from gravatar link but on sidebar it wants to load it from basset cache but it hasn't cached it because dev mode.

this seems to be issue with LOADED state being checked for $avatarLink https://github.com/Laravel-Backpack/CRUD/blob/cca35da38a72d62476d3b832b7348cb07ba1ff53/src/helpers.php#L153

What I've already tried to fix it

nothing

Is it a bug in the latest version of Backpack?

yes

Backpack, Laravel, PHP, DB version

When I run php artisan backpack:version the output is:

PHP VERSION:

8.2.4

PHP EXTENSIONS:

Core, bcmath, calendar, ctype, date, filter, hash, iconv, json, SPL, pcre, random, readline, Reflection, session, standard, mysqlnd, tokenizer, zlib, libxml, dom, PDO, openssl, SimpleXML, xml, xmlreader, xmlwriter, curl, fileinfo, mbstring, Phar, pdo_mysql, pdo_sqlite

LARAVEL VERSION:

11.9.2.0

BACKPACK PACKAGE VERSIONS:

backpack/basset: 1.3.4 backpack/crud: 6.7.15 backpack/generators: v4.0.5 backpack/theme-tabler: 1.2.10

Kasparsu commented 1 month ago

@tabacitu since you come up in gitblame can you explain the need of LOADED if at all. If its not needed and a bug I can make a pull request removing it.

Is it for race conditions when caching has started but we haven't finished yet, but another asset of same type is being loaded? If this is the case then fault lies with basset setting LOADED state when in devmode

jcastroa87 commented 3 weeks ago

Hello @Kasparsu

I hope you are doing well.

Can you share the code you are using for sidebar and load the gravatar

Thanks.