welcome[bot]
commented
1 month ago BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.
Please keep in mind that:
- if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
- even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
- not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
- we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;
Thank you!
-- Justin Case The Backpack Robot
jcastroa87
teunes1
pxpm
Preventing php artisan optimize issues from not working when config cannot be found.
WHY
BEFORE - What was wrong? What was happening before this PR?
Locally everything works but on development server deployments are not possible because the pipeline gets blocked not able to load the uploaders array. Even if it is present and file has read permission.
AFTER - What is happening after this PR?
checking if config is available otherwise fallback on empty array.
Is it a breaking change?
Only for me
How can we test the before & after?
think not needed with this simple code