Laravel-Backpack / FileManager

Admin interface for files & folders, using elFinder.
Other
90 stars 21 forks source link

S3 uploaded files are private by default #10

Closed dmarcos89 closed 3 years ago

dmarcos89 commented 3 years ago

Hi, i have been fighting with this error and couldnt find a solution yet, when trying to upload files to s3, it all works fine, only that files are set as private, not accesible via url.

Looks like the fix was merged to master but not yet reflected in the package: https://github.com/barryvdh/elfinder-flysystem-driver/pull/72

If anyone has a workaround for this, greatly appreciated! Thanks

promatik commented 3 years ago

Hi @dmarcos89!

It seems that @barryvdh haven't tagged a version on https://github.com/barryvdh/elfinder-flysystem-driver/ since that commit.

If this is possible for you, I've used S3 with public files not on AWS but on DigitalOcean (it's also S3 API). Since all files were public, I set the space to public on DO, and it works because all files are public by default, it's a work around.

There are some untagged commits since the last version; https://github.com/barryvdh/elfinder-flysystem-driver/compare/v0.2.1...master and that's one of them, I think there is not much we can do on our side 😕

barryvdh commented 3 years ago

Tagged https://github.com/barryvdh/elfinder-flysystem-driver/releases/tag/v0.3.0

barryvdh commented 3 years ago

And https://github.com/barryvdh/laravel-elfinder/releases/tag/v0.4.7

dmarcos89 commented 3 years ago

Thanks @promatik for the response, and @barryvdh for tagging the new versions! 👏

promatik commented 3 years ago

Perfect 👌 Thank you @barryvdh, this will be helpful for many.

@dmarcos89 with a composer update you get the new updates 🙌