Laravel-Backpack / FileManager

Admin interface for files & folders, using elFinder.
Other
90 stars 21 forks source link

Add Laravel 9 support to FileManager #20

Closed tabacitu closed 2 years ago

tabacitu commented 2 years ago

Also mentioned in https://github.com/Laravel-Backpack/demo/pull/342#issuecomment-1016241251

In order for this package to get L9 support... barryvdh/laravel-elfinder needs to provide L9 support, so it needs an upgrade for league/flysystem, from v1 to v3 (what Laravel 9 uses).

tabacitu commented 2 years ago

@pxpm I've decided this is too big for me. If I start doing this... I won't get my other MUSTs for 4.2 done, until Tuesday.

If you finish everything else assigned to you in the 4.2 MUSTs board, you can also take this on, if I have not assigned myself to it... it's up for grabs.

But. Only if everything else is done and finished and we're happy with 4.2! We should keep in mind that is an add-on, and only 16% of all people using Backpack use FileManager. We gotta focus on the 84% first.

guleswine commented 2 years ago

how i can see laravel-elfinder update dependency

https://github.com/barryvdh/laravel-elfinder/commit/ad0be4d7b21f905abbef7a0d75fea3cf184a848a,

pxpm commented 2 years ago

Hello @guleswine indeed the code is there, but it's not tagged yet. Lastest release is 0.4.7 still.

tabacitu commented 2 years ago

Heads-up guys: I do NOT expect it to be as easy as that. I think some structural changes are needed in its dependency, barryvdh/elfinder-flysystem-driver. I've asked @promatik to take a closer look and he thinks the same way. And I see there's already https://github.com/barryvdh/elfinder-flysystem-driver/pull/83#issuecomment-1055289670 trying to add support to it, but not without problems.

@promatik will take another look, maybe there's a way we can help push this forward and help Barry. But it might take a few weeks to add L9 support to this, so please plan accordingly.

tabacitu commented 2 years ago

Fixed in https://github.com/Laravel-Backpack/FileManager/pull/22