Laravel-Backpack / FileManager

Admin interface for files & folders, using elFinder.
Other
90 stars 21 forks source link

Update common_scripts.blade.php (jqueryui/1.10.4 to jqueryui/1.13.1) #23

Closed AfzalSabbir closed 1 year ago

AfzalSabbir commented 2 years ago

jqueryui/1.10.4 to jqueryui/1.13.1

Because some of designs were breaking which solved in this new version and elFinder itself used this new jQueryUI.

WHY

BEFORE - What was wrong? What was happening before this PR?

?? Some of designs were breaking ( https://prnt.sc/OtGVbr3V1Gnc )

AFTER - What is happening after this PR?

?? This type of breaking are solved ( https://prnt.sc/ynytaD8uXQSu )

HOW

How did you achieve that, in technical terms?

?? Just changed from jqueryui/1.10.4 to jqueryui/1.13.1

Is it a breaking change or non-breaking change?

?? Yes, it was a large issue, without that we could not close or reopen (pop up) the area ever again!

How can we test the before & after?

?? Just change the version in file \resources\views\common_scripts.blade.php

promatik commented 1 year ago

Hi @AfzalSabbir! Thank you for your PR and sorry for the late response.

These updates are going to be merged on the new filemanager version which will be supported by bassets 👌 The PR for it is here; https://github.com/Laravel-Backpack/FileManager/pull/25 I'll close this one for now.