search

Laravel-Backpack / FileManager

Admin interface for files & folders, using elFinder.
Other
94 stars 21 forks source link

Basset Support #25

Closed tabacitu closed 1 year ago

tabacitu commented 1 year ago

WHY

BEFORE - What was wrong? What was happening before this PR?

Some files were loaded from CDN, some from local.

AFTER - What is happening after this PR?

Everything's loaded from local, even though they're pointing to CDNs.

HOW

How did you achieve that, in technical terms?

Use bassets 🐶

Is it a breaking change or non-breaking change?

Breaking

How can we test the before & after?

Don't. It's not working fully yet. The remaining problem is inside common_styles.blade.php... the last file... the theme... yeah, we have a problem there, because all toolbar icons are actually images. So when bassets tries to load the imagines... it can't, because they're not in the same place 🤦‍♂️

promatik commented 1 year ago

Also, improved the installation console command to be inline with the rest of the ecosystem 👌

image

promatik commented 1 year ago

NOTE

This dependes on https://github.com/Laravel-Backpack/basset/pull/20 and https://github.com/Laravel-Backpack/basset/pull/24.

tabacitu commented 1 year ago

Tested, works like a charm! 🎉 Thanks Antonio. I will merge when v6 gets launched. Until then we can use this branch as the v6 one.