search

Laravel-Backpack / FileManager

Admin interface for files & folders, using elFinder.
Other
90 stars 21 forks source link

Switch from using .zip to .tar.gz for basset archives #31

Closed jnoordsij closed 1 year ago

jnoordsij commented 1 year ago

WHY

BEFORE - What was wrong? What was happening before this PR?

The @bassetArchive calls where using the .zip format. This is not supported by default on all PHP installations (see also https://github.com/Laravel-Backpack/basset/pull/60).

AFTER - What is happening after this PR?

Use the .tar.gz format, which was also available for these archives, and is enabled in PHP by default on all installations (see https://www.php.net/manual/en/phar.installation.php).

HOW

How did you achieve that, in technical terms?

Change the archive extensions.

Is it a breaking change or non-breaking change?

No.

How can we test the before & after?

Ensure assets still work fine.

tabacitu commented 1 year ago

Uuu that's brilliant! Thanks @jnoordsij

promatik commented 1 year ago

Nice! Thank you @jnoordsij 👌

Basset supports both .zip and .tar.gz if the .tar.gz is widely supported by PHP, let's move to it 👌