search

Laravel-Backpack / FileManager

Admin interface for files & folders, using elFinder.
Other
94 stars 21 forks source link

Missing Icons/Font #43

Closed arb362 closed 11 months ago

arb362 commented 11 months ago

Problem elFinder Material Theme recently updated to v3.0.0 and in doing so they moved the font from the icons subfolder to the font folder.

image See this commit As a result when basset caches everything it misses this and you receive a 404 error and no icons.

Solution The common_styles.blade will need updated.

Oddly enough, Basset still caches the font file from jsdelivr. I'm assuming that because there is not a specific version specified in the url jsdelivr serves up the last version that has that file?

rk commented 11 months ago

I can confirm that we are also affected by this issue.

Maybe the specific version should be pinned on these assets and manually checked/updated in the theme? This would prevent breaking changes from going untested.

karandatwani92 commented 11 months ago

Discussion continued on the PR.