Closed mahasadhu closed 1 year ago
Both actually 😅
If they merge it we need to do the same too - since we've basically overwritten some of their files.
So let's keep this open at least until there's a resolution there.
Thanks. Cheers!
@tabacitu okay I just submitted a PR to the laravel-elfinder repo
I've also push small changes to prevent json malformed
Hi everyone 🙌
We're here waiting for https://github.com/barryvdh/laravel-elfinder/pull/289 ...
I'm not sure if Barry will ever merge it, laravel-elfinder
looks like it's frozen.
@tabacitu for now I'll close this one, if I'm wrong please re-open 🙌
If more people ever needs this kind of configurations please let us know here in this thread and we may re-think about merging it (before Barry on laravel-elfinder).
Instead of manually type the client configuration in the view, we can set the configuration directly from the laravel config file. List of configuration can be seen here https://github.com/Studio-42/elFinder/wiki/Client-configuration-options-2.1#contents
@tabacitu I'm not sure whether I should make this PR here or at https://github.com/barryvdh/laravel-elfinder . Just close this PR if you think I should make the PR at laravel-elfinder repo