Laravel-Backpack / Generators

Generate files for Backpack projects
http://backpackforlaravel.com
MIT License
314 stars 64 forks source link

Fix deprecation warning #179

Closed mattsches closed 1 year ago

mattsches commented 1 year ago

Fixes #178

WHY

BEFORE - What was wrong? What was happening before this PR?

Deprecation warning, see #178

AFTER - What is happening after this PR?

No deprecation warning

HOW

How did you achieve that, in technical terms?

Used {$filePath} instead of ${filePath}

Is it a breaking change or non-breaking change?

Non-breaking

How can we test the before & after?

Test it in PHP 8.2

welcome[bot] commented 1 year ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

pxpm commented 1 year ago

Thanks @mattsches , very appreciated 🙏

I just need to confirm if all the PHP versions we support, support that syntax. (I think it does, at least from PHP 5.4+)

Just need to confirm that and after I will merge this.

Will check it later 👍

welcome[bot] commented 1 year ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!