Scandir exception when switching languages and no dir exists.

Laravel-Backpack / LangFileManager

A quick interface to edit Laravel language files, for Backpack.

http://backpackforlaravel.com

MIT License

92 stars 42 forks source link

Scandir exception when switching languages and no dir exists. #45

Closed cristianuibar closed 6 years ago

cristianuibar commented 7 years ago

We should handle this with a warning in the UI and not die hard with a full exception.

Or even better, do not show the language in the switcher if the language dir does not exist or create it on the fly and display an empty page -> should suggest to the developer that lang files are missing not scare him.

Screen:

Video: https://www.useloom.com/share/d9840aeb837245c2a68c35d8ce3137ee

lloy0076 commented 7 years ago

I agree (PRs are welcome!) - and I think it's actually a bug.

tabacitu commented 6 years ago

@lucianobapo has already submitted a PR for this, just merged it. Cheers, thank you!