search

Laravel-Backpack / LangFileManager

A quick interface to edit Laravel language files, for Backpack.
http://backpackforlaravel.com
MIT License
92 stars 42 forks source link

Update LangFiles service , Added orginal file name #51

Closed abdelrahmanahmed closed 6 years ago

abdelrahmanahmed commented 6 years ago

Reference #48 . Original name is the name that is stored in the project directory , now the file name with underscore can be viewed without any problem .

abdelrahmanahmed commented 6 years ago

@lloy0076 any news?

lloy0076 commented 6 years ago

Just out of morbid interest, why would we want to use 'original_name'?

abdelrahmanahmed commented 6 years ago

@lloy0076

What i want to do:

I have a translation file name that contains underscore (example_1.php) , and i don't want view this underscore in the tab (more readable) like the following screenshot. What i tried to do original_name : is used to link to the file translation (in the href attribute ) name : is used to view the file name without underscore . image

I don't know why you are removing underscore from file name so i suggested to add another key so we can use both underscored (for link ) and without underscore for view.

lloy0076 commented 6 years ago

So the actual problem is the way the system creates the name(s) for fields?

abdelrahmanahmed commented 6 years ago

@lloy0076 that's correct

lloy0076 commented 6 years ago

Would https://github.com/Laravel-Backpack/CRUD/pull/688 fix it?

abdelrahmanahmed commented 6 years ago

@lloy0076 unfortunately no, it will not solve the translation files name

tabacitu commented 6 years ago

I see no harm in this. Merged!