promatik
commented
6 months ago Hey @yusufkandemir!
We're sorry we took so much to check this PR and now we're closing it 😫
But, I'm happy to announce that we just released a new package Translation Manager. This new package uses Spatie Translation Loader under the hood and will eventually replace LangFileManager, since it works in a more predictable way, using the database to store translations.
I'll close this one for now, let's move our focus and efforts into improving Translation Manager 💪.
This PR aims to refactor things, while not breaking things but also fix the things will lead to breaking in future and present. Even though not much refactoring done, I wish there was unit tests to cover me up. But writing unit tests to big portion of the code seems to be too hard, because it looks coupled and cryptic too much.
There are much more refactoring work need to be done, maybe even rewriting. Especially LangFileManager::displayInputs and LangFileManager::prepareContent and view files.