Laravel-Backpack / LogManager

An interface to preview, download and delete Laravel log files, using Backpack.
http://backpackforlaravel.com
Other
275 stars 56 forks source link

Function strftime() is deprecated #54

Closed kunli0 closed 2 years ago

kunli0 commented 2 years ago

Bug report

What I did:

View a log in Log Manager.

What I expected to happen:

See Log entries.

What happened:

Saw log entries, however emergency logger file is created also to due to deprecated function use.

What I've already did to fix it:

On line 39 of logs.blade.php changed formatLocalized('%d %B %Y') to isoFormat(config('backpack.base.default_date_format'))

On line 40 of logs.blade.php changed formatLocalized('%H:%M') to isoFormat('HH:mm')

Backpack, Laravel, PHP, DB version:

5.0, 9.14, 8.1.2, Maria DB 10.6.7

welcome[bot] commented 2 years ago

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication mediums:

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

maurohmartinez commented 2 years ago

Hi, @kunli0! I can confirm that formatLocalized() was deprecated and I already submitted a PR to address this. This will be closed once the PR is merged.

Thanks for reporting it!

tabacitu commented 2 years ago

Merged and tagged! Thanks @kunli0 !