Laravel-Backpack / LogManager

An interface to preview, download and delete Laravel log files, using Backpack.
http://backpackforlaravel.com
Other
275 stars 56 forks source link

[Minor-Bug] Replace deprecated method formatLocalized() #55

Closed maurohmartinez closed 2 years ago

maurohmartinez commented 2 years ago

WHY

BEFORE - What was wrong? What was happening before this PR?

Some users see logger entries created due to the use of the deprecated method formatLocalized(). Issue reported here

AFTER - What is happening after this PR?

No more logger entries will be created.

HOW

How did you achieve that, in technical terms?

Method formatLocalized() is replaced with isoFormat().

Is it a breaking change or non-breaking change?

Non-breaking.

How can we test the before & after?

Just created couple of errors and checked them on Log Manager.

welcome[bot] commented 2 years ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

tabacitu commented 2 years ago

@maurohmartinez if this is ready for @pxpm to review again, remember to remove yourself from Assigned and put Pedro again. That way, it's easy for everybody to know what they should work on first - we look at "This week". We see our face, it's ours.

welcome[bot] commented 2 years ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!