malle-pietje commented 1 year ago

Bug report

What I did:

Use LogManager to view all log files in the storage/logs directory.

What I expected to happen:

Either be able to preview non-Laravel log files with less functionality or get an appropriate error message informing the user that the log file isn't parsable.

What happened:

The error shown when trying to preview a Laravel schedule log file says "The log file doesn't exist":

But the log file does exist, even though it isn't a regular Laravel log file.

This is an example of such a schedule log file populated by a "chatty" class that fetches data from an external API containing test data:

Fetching invoices from Moneybird...
checking invoices for customer: Anthony and Joyce Traders
checking invoices for customer: Dennis Richard LLC
fetched invoices, page 1
invoice number: 2022-0012
invoice number: 2022-0011
invoice number: 2022-0008
invoice number: 2022-0004
checking invoices for customer: Larsen and Curry Trading
fetched invoices, page 1
invoice number: 2022-0009
invoice number: 2022-0006
invoice number: 2022-0005
Processed 7 invoices: updated 0 invoices, inserted 0 new invoices. Process took 1.657 seconds

What I've already tried to fix it:

Nothing yet.

Backpack, Laravel, PHP, DB version:

Backpack CRUD: 5.4.10 Backpack LogManager: 4.0.8 PHP: 8.1.2

welcome[bot] commented 1 year ago

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication mediums:

Bug Reports, Feature Requests - Github Issues (here);
Quick help (How do I do X) - Gitter Chatroom;
Long questions (I have done X and Y and it won't do Z wtf) - Stackoverflow, using the backpack-for-laravel tag;

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

pxpm commented 1 year ago

Hey @malle-pietje sorry it took so much time to get into this.

We indeed need a better log viewer, unfortunately this had not been a priority and I am afraid it will continue like that at least until we launch v6 (due next months).

Sorry I have nothing new to add here, just to let you know isn't forgotten 👍

Cheers

Laravel-Backpack / LogManager