Laravel-Backpack / LogManager

An interface to preview, download and delete Laravel log files, using Backpack.
http://backpackforlaravel.com
Other
275 stars 56 forks source link

Using named routing instead of hardcode #57

Closed makss closed 1 year ago

makss commented 1 year ago

WHY

BEFORE - What was wrong? What was happening before this PR?

The LogManager supports routing overlays, it provides named routings, but the templates use hardcode rather than named routings, making routing customization difficult.

AFTER - What is happening after this PR?

Routing customization is simplified. It will be enough to copy and configure only one file: routes/backpack/logmanager.php

welcome[bot] commented 1 year ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

tabacitu commented 1 year ago

Totally! Thanks @makss - we'll test and merge this ASAP.

tabacitu commented 1 year ago

Checked, works like a charm! Thank you @makss - merging and tagging right now, so a composer update should get it for you.

welcome[bot] commented 1 year ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!