pxpm
commented
1 year ago Hey @makss thanks for the PR 🙏 Sorry it took some time to get back here!
Indeed I think it's a very clever solution to allow developer to share links to specific log entries. 👏
I am ok with the JS part, but I am afraid I don't agree with html changes.
Why do we need them ? To re-order the logs ? If that's the case woudn't it be better to create some extra configuration like logOrder => 'asc' (defaults to the current order, but developer can configure it) ?
Cheers
WHY
BEFORE - What was wrong? What was happening before this PR?
It is not possible to link to a specific entry in the log file.
AFTER - What is happening after this PR?
Now you can send a link to a specific entry in the log file to someone by mail or add it to a bug report.
HOW
How did you achieve that, in technical terms?
The log file output uses reverse sorting. Therefore, reverse numbering of entries in the log file was also made. Adding new entries will not break previous links.