Laravel-Backpack / LogManager

An interface to preview, download and delete Laravel log files, using Backpack.
http://backpackforlaravel.com
Other
275 stars 56 forks source link

Fix Timezone #69

Closed mariovillani closed 5 months ago

mariovillani commented 5 months ago

Correct timezone is retrieved.

WHY

BEFORE - What was wrong? What was happening before this PR?

isoFormat did not take user's timezone into account.

AFTER - What is happening after this PR?

Correct hours and minutes are shown.

HOW

How did you achieve that, in technical terms?

Adding date_default_timezone_get() as second parameter for createFromTimeStamp() function.

Is it a breaking change or non-breaking change?

Non-breaking change.

How can we test the before & after?

Check if hours and minutes are shown correctly.

welcome[bot] commented 5 months ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

mariovillani commented 5 months ago

Sure! Code updated. If everything is ok, you may proceed with the merge.

welcome[bot] commented 5 months ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!