search

Laravel-Backpack / PermissionManager

Admin interface for managing users, roles, permissions, using Backpack CRUD
http://backpackforlaravel.com
Other
527 stars 168 forks source link

Avoid publish all files #270

Closed promatik closed 3 years ago

promatik commented 3 years ago

Related with #267

Ok, I've been "investigating" 😅 Now we publish;

Config isn't needed, but I think we should publish. 🤷‍♂️ Let me know what you think. Translations aren't needed, laravel loads them. Migrations aren't need, Laravel can load them, but we need to change the code from publishMigrations to loadMigrationsFrom.

I did that on this PR, this makes the migrations mandatory, developers can't opt out. I think it's ok in this case, but let me know if you don't think that way.

promatik commented 3 years ago

By the way, this loadMigrationsFrom thing is great, we should start thinking about migrating to that on all the packages 😅

tabacitu commented 3 years ago

Totally agree - loadMigrationsFrom everywhere!!! We just need to make sure this won't produce a warning, saying the migration is in two places (I get that sometimes but I couldn't get it now when testing this PR... 🤷‍♂️)