Laravel-Backpack / PermissionManager

Admin interface for managing users, roles, permissions, using Backpack CRUD
http://backpackforlaravel.com
Other
527 stars 168 forks source link

Translate the 'users' suffix on the Users Column on RoleCrudController.php #285

Closed beatwiz closed 2 years ago

beatwiz commented 2 years ago

WHY

BEFORE - What was wrong? What was happening before this PR?

Not sure if this was intentionally left out. But the suffix was hardcoded as ' users'.

AFTER - What is happening after this PR?

Suffix translated.

HOW

How did you achieve that, in technical terms?

'suffix'    => ' ' . strtolower(trans('backpack::permissionmanager.users')),

Is it a breaking change or non-breaking change?

Don't think it is.

How can we test the before & after?

It's a super minor PR

welcome[bot] commented 2 years ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

tabacitu commented 2 years ago

Nope, definitely wasn't intentional 👀😀 Thanks for taking the time to submit this @beatwiz , we really appreciate it 🙏

welcome[bot] commented 2 years ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!