Laravel-Backpack / PermissionManager

Admin interface for managing users, roles, permissions, using Backpack CRUD
http://backpackforlaravel.com
Other
527 stars 168 forks source link

Corrects the label for permissions #292

Closed jigius closed 2 years ago

jigius commented 2 years ago

Hi!

Two fixes:

welcome[bot] commented 2 years ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

pxpm commented 2 years ago

Hello @jigius, thanks for the PR's.

From my understanding that function mb_ucfirst does not exist ? https://www.php.net/manual-lookup.php?pattern=mb_ucfirst&scope=quickref

Let me know, Pedro

jigius commented 2 years ago

Hello Pedro.

From my understanding that function mb_ucfirst does not exist ?

The package has the dependency with Laravel-Backpack/CRUD and mb_ucfirst() has been implemented in it.

= Edward

tabacitu commented 2 years ago

Haha that's right! Thank you @jigius , both Pedro and I completely forgot we're the ones who added that 😅

Tested, works, merging, thank you! 🙏

welcome[bot] commented 2 years ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!