Laravel-Backpack / PermissionManager

Admin interface for managing users, roles, permissions, using Backpack CRUD
http://backpackforlaravel.com
Other
527 stars 168 forks source link

registers migration file with new name before publish #304

Closed ssi-anik closed 2 years ago

ssi-anik commented 2 years ago

WHY

According to the documentation/readme file, the snippets are as follows.

# Publish and migrate spatie/laravel-permission
php artisan vendor:publish --provider="Spatie\Permission\PermissionServiceProvider" --tag="migrations"
# Generates a new migration file with date('Y_m_d_His')_migration_file_name.php
php artisan migrate

# Publish and migrate Laravel-Backpack/PermissionManager
php artisan vendor:publish --provider="Backpack\PermissionManager\PermissionManagerServiceProvider" --tag="config" --tag="migrations"
# Generate a new migration file with 2020_xyz_migration_file_name.php
php artisan migrate

Practically, there is nothing wrong. But as soon as you run php artisan migrate:rollback twice or php artisan migrate:refresh, theoretically there is nothing wrong, but the permission manager migration is supposed to be running after the laravel-permission.

Merging this PR will always run the migration after laravel-permission because the file will be generated with a higher timestamp and will get sorted after the laravel-permission migration.

BEFORE - What was wrong? What was happening before this PR?

Explained in why

AFTER - What is happening after this PR?

Explained in why

HOW

How did you achieve that, in technical terms?

??

Is it a breaking change or non-breaking change?

??

How can we test the before & after?

??