update UserUpdateCrudRequest

[otradnix]

i guess we have no this config file permission.table_names.users

WHY

BEFORE - What was wrong? What was happening before this PR?

??

AFTER - What is happening after this PR?

??

HOW

How did you achieve that, in technical terms?

??

Is it a breaking change or non-breaking change?

??

How can we test the before & after?

??

[welcome[bot]]

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

• if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
• even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
• not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
• we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

-- Justin Case The Backpack Robot

[pxpm]

Hello @otradnix

Thanks for the contribution.

We use it with a default value of "users" but probably we can add it on permission file too.

Did you try adding that key to your permission.php config file ? It should work as expected.

If not try running php artisan cache:clear and php artisan config:clear

Let me know, Pedro

[otradnix]

Hello @otradnix

Thanks for the contribution.

We use it with a default value of "users" but probably we can add it on permission file too.

Did you try adding that key to your permission.php config file ? It should work as expected.

If not try running php artisan cache:clear and php artisan config:clear

Let me know, Pedro

Hello, for sure we can add it to config file called 'permission' but isn't better use it like i wrote ? By default permission is empty about table_names.users parameter and you have to review a lot of files before know about it.

Thank's for help with this tiny thing.

[pxpm]

Hey there @otradnix Simple things make the life of a lot of people better. I think you are right in the point that we don't have it in the permission config and that could be misleading to the users, I am just wondering if it would be better to change the code and get the table name from model or expose the config in the file by default so users can change it.

I think the only way to do it in this version is adding it to the config file otherwise it would be a breaking change that we can only push in the next major version.

I will think better about it and tomorrow I will get back here. Thanks for taking the time to submit the PR. Cheers

[pxpm]

Thanks for the PR @otradnix .

I get the issue now 🙏 I think @gleb-svitelskiy PR was better to fix this as Laravel allow us to feed the model and it will call the get table internaly.

I will review and probably merge @gleb-svitelskiy PR that will fix this is a similar maner.

Cheers