checklist dependency definition added

munjaldevelopment commented 1 year ago

Checklist dependency definition has been added in setupListOperation

BEFORE - User Role & permission was showing different earlier

??

AFTER - will show Role / permission as Checklist dependency

??

HOW

We have added checklist_dependency in setupListOperation function

non-breaking change

You can check that from checkout using this branch & "crud" repo with "default-field-value" branch.

welcome[bot] commented 1 year ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

-- Justin Case The Backpack Robot

tabacitu commented 1 year ago

@munjaldevelopment - I don't understand what this does and why it's needed... could you please rephrase? Or add a screenshot?...

tabacitu commented 1 year ago

OOOOHH... so what this does... is: use the new "checklist dependency" column on the Users CRUD. Correct?

Ok... let's work on wording a little bit @munjaldevelopment . Clean up your mind - you're not you, you're me, someone who has no idea what this PR does. Go through the PR name and description. Is there any way to understand that, from the title/content? 😀

This is obviously not necessary now that I understand, but please take a moment to reword the title and description. Try to make it clear what this PR does. It's very important for collaboration to communicate clearly, and this exercise will help set the standard for the next PRs. Also, please don't edit the headlines. Your answers to the headings would look so much better if they were in normal text, not headline.

Sorry to be so pretentious about this, but I cannot stress enough how important good communication is. Have you read The Whole Fruit Manifesto as we asked?

munjaldevelopment commented 1 year ago

Understood @Cristian Tabacitu @.***> I didn't change the title & description. May be I need to explain more what I have done?

https://github.com/the-whole-fruit/manifesto Thanks for sharing this. I got the idea now.

On Mon, Oct 3, 2022 at 11:12 AM Cristian Tăbăcitu @.***> wrote:

OOOOHH... so what this does... is: use the new "checklist dependency" column on the Users CRUD. Correct?

Ok... let's work on wording a little bit @munjaldevelopment https://github.com/munjaldevelopment . Clean up your mind - you're not you, you're me, someone who has no idea what this PR does. Go through the PR name and description. Is there any way to understand that, from the title/content? 😀

This is obviously not necessary now that I understand, but please take a moment to reword the title and description. Try to make it clear what this PR does. It's very important for collaboration to communicate clearly, and this exercise will help set the standard for the next PRs. Also, please don't edit the headlines. Your answers to the headings would look so much better if they were in normal text, not headline.

Sorry to be so pretentious about this, but I cannot stress enough how important good communication is. Have you read The Whole Fruit Manifesto https://github.com/the-whole-fruit/manifesto as we asked?

— Reply to this email directly, view it on GitHub https://github.com/Laravel-Backpack/PermissionManager/pull/311#issuecomment-1264961868, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRGM2GM3KGU4H2JQSHLOL3WBJW2VANCNFSM6AAAAAAQYOYSKI . You are receiving this because you were mentioned.Message ID: @.***>

tabacitu commented 1 year ago

Yes, that's what I'm saying 😀

munjaldevelopment commented 1 year ago

I will share document soon.

On Mon, 3 Oct 2022, 11:04 am Cristian Tăbăcitu, @.***> wrote:

@munjaldevelopment https://github.com/munjaldevelopment - I don't understand what this does and why it's needed... could you please rephrase? Or add a screenshot?...

— Reply to this email directly, view it on GitHub https://github.com/Laravel-Backpack/PermissionManager/pull/311#issuecomment-1264957891, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRGM2DTYE7TW4NYTG5EOC3WBJV57ANCNFSM6AAAAAAQYOYSKI . You are receiving this because you were mentioned.Message ID: @.***>

munjaldevelopment commented 1 year ago

"Role/Permission" individual column commented & combined "checklist_dependency" to show "Roles & Permission"

tabacitu commented 11 months ago

Hmmm sorry but I don't agree with this any more. I don't think we should add the checklist_dependency column to the List operation... I think it's much better to use it inside the Show operation. TBH I don't know why we don't have that already, seems super-useful to be able to see... for a particular user... what roles and permissions they have.

So I've gone ahead and moved it to the Show operation, and I'll merge this shortly.

Thanks for the PR @munjaldevelopment !

welcome[bot] commented 11 months ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

give your opinion on other Github Issues & PRs;
chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!

Laravel-Backpack / PermissionManager