Laravel-Backpack / PermissionManager

Admin interface for managing users, roles, permissions, using Backpack CRUD
http://backpackforlaravel.com
Other
516 stars 166 forks source link

Update README so Spatie Permission will publish migrations #321

Closed kde99 closed 1 year ago

kde99 commented 1 year ago

WHY

Doing the normal "php artisan vendor:publish --provider="Spatie\Permission\PermissionServiceProvider" --tag="migrations"" doesn't work as it's not called migrations in code but "permission-migrations".

BEFORE - What was wrong? What was happening before this PR?

Doing the installation process you won't get the migration for the permission tables.

AFTER - What is happening after this PR?

Using the right command you do get the migration and the config file.

HOW

How did you achieve that, in technical terms?

Change the migration and config tag to prefix with "permissions-"

Is it a breaking change or non-breaking change?

Breaks nothing.

How can we test the before & after?

Try to install then you'll see it doesn't publish the migration so the package won't work. Use the correct command then migrate now it does.

welcome[bot] commented 1 year ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

welcome[bot] commented 1 year ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!

pxpm commented 1 year ago

Thank you @kde99 🙏