Laravel-Backpack / PermissionManager

Admin interface for managing users, roles, permissions, using Backpack CRUD
http://backpackforlaravel.com
Other
527 stars 168 forks source link

Correct the user model configuration key #337

Closed gleb-svitelskiy closed 1 year ago

gleb-svitelskiy commented 1 year ago

WHY

BEFORE - What was wrong? What was happening before this PR?

Fixing this bug.

AFTER - What is happening after this PR?

Fixing this bug.

HOW

How did you achieve that, in technical terms?

I'm using the correct config key.

Is it a breaking change or non-breaking change?

Non-breaking change.

How can we test the before & after?

Try to create a new user with overridden Backpack user model.

welcome[bot] commented 1 year ago

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

Thank you!

-- Justin Case The Backpack Robot

pxpm commented 1 year ago

Thanks for the pull request @gleb-svitelskiy really appreciate the time you spent here.

Unfortunately like I said in the issue comment we cannot merge this as this does not address your problem.

If you are using different tables you should configure them in the spatie config file like I said in https://github.com/Laravel-Backpack/CRUD/issues/5281#issuecomment-1683957080

Cheers

pxpm commented 1 year ago

Hey @gleb-svitelskiy I got the issue now. And I've checked Laravel docs to make sure it also accepts the model instead of the table name.

I will properly review this PR tomorrow or monday, but it's 99% guaranteed to get merged.

Sorry I need to spend some time here before merging that I can't afford today.

Thanks again, and sorry for the confusion 🙏

pxpm commented 1 year ago

Thanks again @gleb-svitelskiy and sorry for the confusion at first.

Merged and tagged 🙏

welcome[bot] commented 1 year ago

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

party

If you want to help out the community in other ways, you can:

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!