fix php 8.2 deprecation warnings

[makss]

WHY

BEFORE - What was wrong? What was happening before this PR?

logs\deprecation-warnings.log

[2023-10-19 07:43:25] staging.WARNING: Creation of dynamic property Backpack\PermissionManager\app\Http\Controllers\RoleCrudController::$role_model is deprecated in /vendor/backpack/permissionmanager/src/app/Http/Controllers/RoleCrudController.php on line 20
[2023-10-19 07:43:25] staging.WARNING: Creation of dynamic property Backpack\PermissionManager\app\Http\Controllers\RoleCrudController::$permission_model is deprecated in /vendor/backpack/permissionmanager/src/app/Http/Controllers/RoleCrudController.php on line 21

[2023-10-19 22:39:31] staging.WARNING: Creation of dynamic property Backpack\PermissionManager\app\Http\Controllers\PermissionCrudController::$role_model is deprecated in /vendor/backpack/permissionmanager/src/app/Http/Controllers/PermissionCrudController.php on line 20
[2023-10-19 22:39:31] staging.WARNING: Creation of dynamic property Backpack\PermissionManager\app\Http\Controllers\PermissionCrudController::$permission_model is deprecated in /vendor/backpack/permissionmanager/src/app/Http/Controllers/PermissionCrudController.php on line 21

PHP 8.2 Deprecated https://php.watch/versions/8.2/dynamic-properties-deprecated

Similar Issue: https://github.com/Laravel-Backpack/CRUD/pull/5082

[welcome[bot]]

BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.

Please keep in mind that:

• if this constitutes a breaking change, it might take quite a while for this to get merged; we try to emulate the Laravel release cycle as much as possible, so developers can upgrade both software once; this means a new big release every ~6 months;
• even if it's a non-breaking change, it might take a few days/weeks for the PR to get merged; unless it's a no-brainer, we like to have some community feedback on new features, before we merge them; this leads to higher-quality code, in the end; we learnt this the hard way :-)
• not all PRs get merged; sometimes we just have to hold out new features, to keep the packages lean; sometimes we don't include features that only apply to niche use cases;
• we're not perfect; if you think we're wrong, call us out on it; but in a kind way :-) we all make mistakes, best we learn from them and build better software together;

Thank you!

-- Justin Case The Backpack Robot

[karandatwani92]

Hey @makss, thanks for the PR.

@pxpm can you please review this small & quick fix?

[pxpm]

Hey @makss thanks for the PR. 🙏 Really appreciated.

@karandatwani92 I think this just needs types before merging.

protected string $role_model; 
protected string $permission_model; 

@makss can you add types for those ? If you don't have time/desire to do it me or @karandatwani92 can push this foward 🙏

Cheers

[makss]

@pxpm yes, you are right, I specified the type of variables.

[pxpm]

Thanks @makss 🙏 much appreciated!

[welcome[bot]]

WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.

If you want to help out the community in other ways, you can:

• give your opinion on other Github Issues & PRs;
• chat with others in the Gitter Chatroom (usually for quick help: How do I do X);
• answer Backpack questions on Stackoverflow; you get points, people get help; you can subscribe to the backpack-for-laravel tag by adding a new filter; that will send you emails when new questions come up with our tag;

Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!

-- Justin Case The Backpack Robot

P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!