Closed hafijul233 closed 5 months ago
BOOM! Your first PR with us, thank you so much! Someone will take a look at it shortly.
Please keep in mind that:
Thank you!
-- Justin Case The Backpack Robot
Hi @hafijul233
Thanks a lot for this great feature, I test it, and it is working ok. I will ask @pxpm to make a final check.
Thanks again.
Cheers.
@jcastroa87 I noticed that the setting model class alias it's also pointing to The Backpack Setting class. I will try testing that the Laravel alias loader can be configurable.
I finalize my tweaks on the model class configurable option.
WHOOP-WHOOP! Congrats, your first PR on this repo has officialy been merged.
If you want to help out the community in other ways, you can:
backpack-for-laravel
tag by adding a new filter; that will send you emails when new questions come up with our tag;Again. Thank you for the PR. You are a wonderful person. Keep 'em coming :-) Cheers!
-- Justin Case The Backpack Robot
P.S. Help in the Backpack community is rewarded with free Backpack commercial licenses. It's the least we can do. If you feel you've helped the community with PRs, help & other stuff, please shoot Tabacitu an email and ask him if you qualify for free licenses. You scratch my back, I scratch your back. Thank you!
Thank you very much @hafijul233
Very clean and direct to the point, a maintainer dream of PR 🙏
Will be available on next version with a composer update
.
Cheers
WHY
I wanted to have more control over how settings are handled, not just the table name.
BEFORE - What was wrong? What was happening before this PR?
The Setting model that comes with package is called by setting crud controller and that was hardcoded.
AFTER - What is happening after this PR?
Now user will have more flexible options to change the model class that is called and modify or extend functionality as per project need.
HOW
How did you achieve that, in technical terms?
model
.Is it a breaking change or non-breaking change?
Non-Breaking Change
How can we test the before & after?
Change the model field value on configuration file and output config values will be given model instances.