Laravel-Backpack / Settings

Application settings interface for Backpack (for Laravel 6).
http://backpackforlaravel.com
Other
248 stars 78 forks source link

[Bug] Doesn't work with non-default guard #76

Closed chescos closed 6 years ago

chescos commented 6 years ago

Bug report

What I did:

Used separate auth guards for the admin panel and website.

What I expected to happen:

That I could still update Settings with this addon.

What happened:

I got a "403 Forbidden" error when trying to update a setting. That's because the authorize method in src/app/Http/Requests/SettingRequest.php only checks the default guard. It should check for the guard that is specified in config/backpack/base.php.

What I've already tried to fix it:

-

Backpack, Laravel, PHP, DB version:

-

welcome[bot] commented 6 years ago

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication mediums:

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

tabacitu commented 6 years ago

You're totally right @chescos - thank you. Just merged @ShamarKellman 's PR which fixes this, so a composer update should fix it for you.

Thanks again for reporting this. Cheers!