search

Laravel-Backpack / activity-log

MIT License
29 stars 7 forks source link

show array attributes like extras #15

Closed tabacitu closed 1 year ago

tabacitu commented 1 year ago

Before this PR, if you had a column like extras that had changed... you'd get a big fat error because you can't convert array to string. After this PR, it splits up the array into a list:

CleanShot 2023-08-29 at 13 21 15@2x

It's not exactly pretty... but at least there's no error right?

tabacitu commented 1 year ago

Update: since I was already on this file, I ended up doing the MUST and SHOULDs mentioned in https://github.com/Laravel-Backpack/activity-log/issues/12

So now it looks like this:

CleanShot 2023-08-29 at 13 35 10@2x

Which is... not great... but better I think.

tabacitu commented 1 year ago

Merging into the v6 branch, since it's due for launch tomorrow 👀