Laravel-Backpack / basset

Better asset helpers for Laravel apps.
MIT License
155 stars 11 forks source link

Basset Fresh might not work 100% of the time #70

Closed tabacitu closed 1 year ago

tabacitu commented 1 year ago

I've noticed this in our online demo. But the issue happens on my local too. After I've already run php artisan basset:fresh... subsequent calls DO NOT seem to actually do a fresh. They are just too fast.

Soo... what's happening here? 👀 Any idea @promatik ?

pxpm commented 1 year ago

Me and @tabacitu had debugged this a little bit further.

We suspect the issue may be that the artisan calls (in basset:fresh command) are made asynchronously, so the second one does not wait for the first to finish.

Instead of directly calling artisan we may need to use Symfony Process class, that we can wait until we get a "all good" output from the first command.

@promatik

promatik commented 1 year ago

Fix provided by https://github.com/Laravel-Backpack/basset/pull/73 👌