search

Laravel-Backpack / basset

Better asset helpers for Laravel apps.
MIT License
155 stars 11 forks source link

Avoid to verify SSL on local #96

Closed promatik closed 1 year ago

promatik commented 1 year ago

Fixes https://github.com/Laravel-Backpack/basset/issues/95.

This is a fix for local development where developers use self signed certificates (like the ones provided by Laragon or similar).

ERROR - cURL error 60: SSL certificate problem: self signed certificate (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://backpack.test/storage/basset/vendor/backpack/basset/tests/Helpers/basset-test.js.

This will make the HTTP to now verify the requests when dev_mode === true.

promatik commented 1 year ago

After discussing this with Cristian, let's move to a proper configuration instead of depending on dev_mode.

It should be 'verify_ssl_certificate' => true.

Astriel commented 1 year ago

Thank you guys for your work ! Will try this once it's merged to be able to validate it.

tabacitu commented 1 year ago

@pxpm looks good to me. Anything holding us back from merging this?

pxpm commented 1 year ago

@pxpm looks good to me. Anything holding us back from merging this?

I had already reviewed this but didn't came back here after @promatik did the changes.

LGTM. Merged, Will tag a new version in a few moments after I test and merge other PR.

Thanks for the ping.

Cheers

Astriel commented 1 year ago

Basset is working well now. But the coreui-v4 is still broken even if basset is now fully working.