Laravel-Backpack / community-forum

A workspace to discuss improvement and feature ideas, before they're actually implemented.
28 stars 0 forks source link

Switch to using accessible colours - a darker purple [Feature Request] #355

Open lukew-cogapp opened 1 year ago

lukew-cogapp commented 1 year ago

Hello,

We're using Backpack on a project but have noticed that the purple you use is not accessible on a white background (nor is the blue alternative).

They both fail to meet WCAG AA colour contrast ratio. Whilst we're aware that we can create overrides for these, it would be nice for the wider world (and especially those with any visual impairments) to have this available by default.

Alternatively, a simple-to-implement "primary colour" configuration variable would be great, so that we could change this to something accessible without needing to go through the full custom config route.

Thank you.

Pasted image from https://webaim.org/resources/contrastchecker/: image

welcome[bot] commented 1 year ago

Hello there! Thanks for opening your first issue on this repo!

Just a heads-up: Here at Backpack we use Github Issues only for tracking bugs. Talk about new features is also acceptable. This helps a lot in keeping our focus on improving Backpack. If you issue is not a bug/feature, please help us out by closing the issue yourself and posting in the appropriate medium (see below). If you're not sure where it fits, it's ok, a community member will probably reply to help you with that.

Backpack communication channels:

Please keep in mind Backpack offers no official / paid support. Whatever help you receive here, on Gitter, Slack or Stackoverflow is thanks to our awesome awesome community members, who give up some of their time to help their peers. If you want to join our community, just start pitching in. We take pride in being a welcoming bunch.

Thank you!

-- Justin Case The Backpack Robot

pxpm commented 1 year ago

Hello @lukew-cogapp

Thanks for the suggestion and the tip about the contrast, I've never thought about it, but after seeing it, you can't un-seen. It's like I want to change the main color that our theme uses NOW!

Unfortunately can't do it, but for v6 we will sure pay more attention to those details in our color pallet. Also for v6 (due in a few months), we will be doing a major overhaul in Backpack themes sector, so that changing colors and stuff like that doesn't involve building steps.

Out of curiosity I went to check about the purple in github Close with comment button: image

It seems they already know about https://webaim.org/resources/contrastchecker/ 🙃 image

Thanks again for the suggestion @lukew-cogapp , it was a very good one I think 🙏

lukew-cogapp commented 1 year ago

Hi @pxpm

Thanks for getting back to me! I absolutely understand that it's not possible to do now, but we eagerly await v6!

I'm happy to lend an opinion from an accessibility point of view at a later date. I can thoroughly recommend running backpack through this browser extension and you'll pick up the majority of issues without needing to read the full WCAG guidelines :)