search

Laravel-Backpack / demo

A working demo of Laravel with all Backpack packages installed.
http://backpackforlaravel.com
Other
332 stars 165 forks source link

move address_google field definition #436

Closed tabacitu closed 2 years ago

tabacitu commented 2 years ago

Notice this points to https://github.com/Laravel-Backpack/demo/pull/430

WHY

BEFORE - What was wrong? What was happening before this PR?

We were loading all fields as column, but not address_google because that was manually added in setupCreateOperation().

AFTER - What is happening after this PR?

address_google gets loaded both as a field (in Monster CRUD) and as a column (in ColumnMonster CRUD).

HOW

How did you achieve that, in technical terms?

I moved the address_google field definition to the getFieldsArrayForTimeAndSpaceTab() method.

Is it a breaking change or non-breaking change?

Non-breaking.

How can we test the before & after?

No need.

tabacitu commented 2 years ago

Heads-up Munjal - I created this PR towards your https://github.com/Laravel-Backpack/demo/pull/430 branch and merged it.